Skip to content

refactor(security-center): Rename securitycenter_list_findings_at_time region tag according new securitycenter_list_findings_within_time_range#4380

Merged
Kef131 merged 2 commits into
mainfrom
refactor(security-center)_rename_securitycenterlistfindingsattime_region_tag
Jul 14, 2026
Merged

refactor(security-center): Rename securitycenter_list_findings_at_time region tag according new securitycenter_list_findings_within_time_range#4380
Kef131 merged 2 commits into
mainfrom
refactor(security-center)_rename_securitycenterlistfindingsattime_region_tag

Conversation

@Kef131

@Kef131 Kef131 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/517939862

Updated the region tag from securitycenter_list_findings_at_time to securitycenter_list_findings_within_time_range. This is a requirement after migration of Java region tag from GoogleApis to Java-docs-samples, to be able to have ownership over the file and be able to address a decommission on Java.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@Kef131
Kef131 requested review from a team as code owners July 10, 2026 22:26
@snippet-bot

snippet-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the api: securitycenter Issues related to the Security Command Center API. label Jul 10, 2026
@Kef131 Kef131 self-assigned this Jul 10, 2026
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jul 10, 2026
@Kef131 Kef131 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the region tag comments in security-center/snippets/v1/listFindingsAtTime.js from securitycenter_list_findings_at_time to securitycenter_list_findings_within_time_range. There are no review comments, and I have no feedback to provide.

@Kef131
Kef131 requested a review from angelcaamal July 14, 2026 16:35

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the securitycenter_list_findings_at_time region tag is not being used in the documentation, so the update looks good to me.

@Kef131 Kef131 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 14, 2026
@Kef131
Kef131 merged commit 38fad06 into main Jul 14, 2026
19 of 21 checks passed
@Kef131
Kef131 deleted the refactor(security-center)_rename_securitycenterlistfindingsattime_region_tag branch July 14, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: securitycenter Issues related to the Security Command Center API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants