chore: deprecate experimental host option/parameter#4575
Merged
olavloite merged 3 commits intoJul 2, 2026
Conversation
…n PgAdapterTestEnv - Dynamically handle USE_PLAIN_TEXT to toggle http vs https. - Add support for injecting SPANNER_OMNI_CLIENT_CERT and SPANNER_OMNI_CLIENT_KEY properties to the client configuration.
sagnghos
marked this pull request as ready for review
July 1, 2026 11:04
olavloite
reviewed
Jul 2, 2026
| && propertyMap.containsKey(IS_EXPERIMENTAL_HOST_PROPERTY_NAME); | ||
| && (commandLine.hasOption(OPTION_JDBC_PROPERTIES) | ||
| && (propertyMap.containsKey("isExperimentalHost") | ||
| || SPANNER_OMNI_TYPE.equalsIgnoreCase(propertyMap.get(TYPE_PROPERTY_NAME)))); |
Collaborator
There was a problem hiding this comment.
This lookup in propertyMap will fail if someone added Type=omni to the connection string. This is actually a generic problem for multiple other properties here as well. Can we change the type of map that is used for this to this:
Map<String, String> properties = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);…meters - Fixes bug where 'Type=omni' or other mixed-cased keys were ignored. - Replace HashMap with TreeMap(String.CASE_INSENSITIVE_ORDER) when parsing JDBC properties. - Remove deprecated setExperimentalHost.
olavloite
approved these changes
Jul 2, 2026
olavloite
merged commit Jul 2, 2026
f449f95
into
GoogleCloudPlatform:postgresql-dialect
45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uptaking change in googleapis/google-cloud-java#13236 to deprecate (experimental host / external host) parameters / options to uptake the new Type parameter
To run Integration test against Spanner Omni use below parameters:
Additional change in ITLiquibaseTest
Fix ProcessBuilder Deadlock in ITLiquibaseTest
Problem: ITLiquibaseTest was prone to freezing indefinitely when executing the mvn liquibase subprocess. The test code attempted to read the process's stderr stream to completion before reading stdout. Because the Liquibase Maven plugin generates a massive amount of stdout logs (fetching dependencies, evaluating changelogs), the OS stdout buffer would fill up, causing the subprocess to pause. This resulted in an I/O deadlock: Java was waiting for stderr to finish, while the subprocess was waiting for Java to clear stdout.
Solution: Merged the error and output streams by setting builder.redirectErrorStream(true) on the ProcessBuilder. This routes all stderr output directly into stdout, allowing the test thread to continuously drain a single unified stream. This prevents the buffer from filling up and completely eliminates the deadlock.