This repository was archived by the owner on Jan 12, 2022. It is now read-only.
handle health checks in middleware#11
Merged
andrewsg merged 2 commits intoGoogleCloudPlatform:masterfrom Jun 3, 2015
andrewsg:health_checks
Merged
handle health checks in middleware#11andrewsg merged 2 commits intoGoogleCloudPlatform:masterfrom andrewsg:health_checks
andrewsg merged 2 commits intoGoogleCloudPlatform:masterfrom
andrewsg:health_checks
Conversation
There was a problem hiding this comment.
do we need to differentiate between the old vm runtime and the multi-core runtime? Or both of them use the same name appengine-python-vm-runtime-0.1.tar.gz
Member
Author
There was a problem hiding this comment.
Right now the plan is for the multicore runtime to supersede the old one entirely, so there's no need to distinguish between them except temporarily.
|
LGTM |
andrewsg
added a commit
that referenced
this pull request
Jun 3, 2015
handle health checks in middleware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds simple (stateless) health check handling as a stopgap until nginx health checks are enabled in MVMs.
I also went ahead and added a missing license block to setup.py and made some gpylint-recommended style changes.
R: @mingzhaodotname CC: @isdal