This repository was archived by the owner on Jan 12, 2022. It is now read-only.
update README and Dockerfile#13
Merged
andrewsg merged 1 commit intoGoogleCloudPlatform:masterfrom Jun 17, 2015
andrewsg:readme
Merged
update README and Dockerfile#13andrewsg merged 1 commit intoGoogleCloudPlatform:masterfrom andrewsg:readme
andrewsg merged 1 commit intoGoogleCloudPlatform:masterfrom
andrewsg:readme
Conversation
Member
Author
|
The idea behind the Dockerfile is that once I cut a release, the Docker build process should be able to grab the binary directly from github's releases page with no intermediate steps. Unfortunately I can't test this until the repo is made public and the release cut; if it doesn't work I have a backup plan that includes intermediate steps, or we could alternatively host the binary ourselves in a storage bucket. |
|
LGTM Might consider adding some examples :-). Not required though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @mingzhaodotname CC: @apolito @gbin @isdal