This repository was archived by the owner on Jan 12, 2022. It is now read-only.
add middleware to monkey-patch os.env to be thread local for GAE compatibility#4
Merged
andrewsg merged 1 commit intoGoogleCloudPlatform:masterfrom Feb 12, 2015
andrewsg:environment
Merged
add middleware to monkey-patch os.env to be thread local for GAE compatibility#4andrewsg merged 1 commit intoGoogleCloudPlatform:masterfrom andrewsg:environment
andrewsg merged 1 commit intoGoogleCloudPlatform:masterfrom
andrewsg:environment
Conversation
Member
Author
|
@mingzhaodotname please review minor change |
There was a problem hiding this comment.
where do you get appengine_config?
Member
Author
There was a problem hiding this comment.
Line 37: appengine_config = vmconfig.BuildVmAppengineEnvConfig()
There was a problem hiding this comment.
sorry, didn't see the hidden lines.
And thanks a lot for the great comments.
LGTM
andrewsg
added a commit
that referenced
this pull request
Feb 12, 2015
add middleware to monkey-patch os.env to be thread local for GAE compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.