Skip to content
This repository was archived by the owner on Jan 12, 2022. It is now read-only.

Add ndb test#80

Merged
bryanmau1 merged 1 commit intomasterfrom
add_ndb_test
Apr 19, 2016
Merged

Add ndb test#80
bryanmau1 merged 1 commit intomasterfrom
add_ndb_test

Conversation

@bryanmau1
Copy link
Copy Markdown
Contributor

R: @jonparrott
Hi Jon, I'm about to add a number of tests covering our supported APIs. Could you take a quick look at this one and see if it fits with the pytest way of writing tests?

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Comment thread tests/e2e/tests/ndb_test.py Outdated


@pytest.fixture
def setup():
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call this ctx instead, and might as well return the ctx in case you want to use it in a test. :)

@theacodes
Copy link
Copy Markdown

Looks mostly good, one nit. Please also squash your commits.

@bryanmau1 bryanmau1 merged commit 953b110 into master Apr 19, 2016
@bryanmau1 bryanmau1 deleted the add_ndb_test branch April 19, 2016 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants