Conversation
| virtualenv env | ||
| env/bin/pip install -r requirements.txt | ||
| env/bin/python main.py https://${GCLOUD_PROJECT}.appspot.com/ | ||
| env/bin/python main.py http://${GCLOUD_PROJECT}.appspot.com/ |
There was a problem hiding this comment.
Generates an annoying error. Can chat offline. Has to do with SSL.
There was a problem hiding this comment.
is it requests/urllib3 screaming? If so, we just need to do pip install requests[security] instead of requests. ;)
|
Thanks for the comments. Updated the tests. |
|
|
||
|
|
||
| @pytest.fixture | ||
| def request_id(): |
There was a problem hiding this comment.
this fixture probably isn't necessary unless you plan to add a lot more tests that do this.
There was a problem hiding this comment.
I'll leave this fixture here. Other tests I agree they're overkill, but this one is dependent per-request and if we ever upgrade our test harness to be able to test multiple requests this will be useful.
|
LGTM. I'll follow up with a commit to enable linting and fix the imports. :) |
3 participants
Adding a set of basic e2e tests demonstrating that the APIs listed here can at least be accessed.
Note: The logging API does not appear to be supported.
R: @jonparrott
CC: @andrewsg