Skip to content

Conversation

@iennae
Copy link
Contributor

@iennae iennae commented Sep 3, 2024

Description

unblocks merging of #12544

@iennae iennae requested review from a team as code owners September 3, 2024 21:40
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Sep 3, 2024
Copy link
Contributor

@briandorsey briandorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iennae iennae added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 4, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 4, 2024
@glasnt
Copy link
Contributor

glasnt commented Sep 4, 2024

Tests appear to be failing because there's no pytest defined for Python 3+

pytest==4.6.11; python_version < '3.0'

(this is a similar issue to what I am getting in another PR, will update with suggested resolution)

(why were these tests green earlier? they appear to be kokoro skipped last time this sample was run)

@iennae
Copy link
Contributor Author

iennae commented Sep 4, 2024

thank you @glasnt ! I was wondering what was up

@glasnt
Copy link
Contributor

glasnt commented Sep 4, 2024

@davidcavazos
Copy link

I reproduced this locally. I think six is not an indirect dependency anymore. I think we can simply add it to the dependencies.

@iennae iennae merged commit e9d8d7d into main Oct 7, 2024
@iennae iennae deleted the sigje-resolve-lint-issues-iap branch October 7, 2024 18:48
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
…#12557)

* fix(gae): resolve linting issues in main_test.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: resolve linting issues where pytest not available for python versions

* add requirement six

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: David Cavazos <dcavazos@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants