docs(alm): add ui samples - #14459
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a Flask-based UI example for Apigee API generation and deployment, along with its Docker configuration and static assets. Feedback highlights a critical command injection vulnerability in app.py due to unsafe shell execution of user-controlled input. Additionally, several files contain redundant or entirely commented-out code—including active_app_backup.py, app2.py, and sections within app.py and the Dockerfile—which should be removed to maintain code cleanliness.
|
ALM isn't in Snippet-Bot's official product list yet, but |
|
Can a maintainer please add the snippet-bot:no-prefix-req label? ALM isn't registered as a product prefix yet. |
|
@GoogleCloudPlatform/python-samples-reviewers Could someone please take a look? I've addressed the formatting, security, and license feedback from the automated bots. |
XrossFox
left a comment
There was a problem hiding this comment.
I have a few questions here, also, is there a buganizer number for this PR?.
Thanks for the review! Addressed all the comments. b/538721412 is the buganizer. |
XrossFox
left a comment
There was a problem hiding this comment.
Okay, it looks like you have a bunch of linting issues, now that the workflows are running. One last thing, since we dont have pipelines for automated testing anymore, we made a requirement to attach execution screenshot of the code sample to make sure it is running.
|
Here are the screenshots! https://screenshot-v2.corp.google.com/54FgMhY35MHpacM |
|
requested screenshots for the reviewer: |
|
Lint errors fixed as well. PTAL! |
XrossFox
left a comment
There was a problem hiding this comment.
I've seen the screnshots. Linter is now passing. LGTM.
|
@XrossFox Thanks for reviewing! Could you please formally submit an Approving review in GitHub and merge the PR when ready? (I don't have merge permissions on this repository). |
Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions