Skip to content

chore: bump skaffold schema version to v4beta1 - #8034

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:create-v4beta1-schema
Nov 4, 2022
Merged

chore: bump skaffold schema version to v4beta1#8034
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:create-v4beta1-schema

Conversation

@aaron-prindle

@aaron-prindle aaron-prindle commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Related to #5132 and #7990

@aaron-prindle
aaron-prindle requested a review from a team as a code owner November 3, 2022 19:45
@aaron-prindle
aaron-prindle requested a review from tejal29 November 3, 2022 19:45
@aaron-prindle
aaron-prindle force-pushed the create-v4beta1-schema branch 3 times, most recently from 64b9254 to 701ca79 Compare November 3, 2022 20:40
@codecov

codecov Bot commented Nov 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #8034 (aae85f3) into main (290280e) will decrease coverage by 3.87%.
The diff coverage is 54.09%.

@@            Coverage Diff             @@
##             main    #8034      +/-   ##
==========================================
- Coverage   70.48%   66.61%   -3.88%     
==========================================
  Files         515      598      +83     
  Lines       23150    28984    +5834     
==========================================
+ Hits        16317    19307    +2990     
- Misses       5776     8250    +2474     
- Partials     1057     1427     +370     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 393 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread pkg/skaffold/schema/v3/config.go Outdated

@gsquared94 gsquared94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaron-prindle
aaron-prindle enabled auto-merge (squash) November 4, 2022 01:21
@aaron-prindle
aaron-prindle merged commit 446a169 into GoogleContainerTools:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants