fix: new condition to create hydrate-dir only if a kpt renderer or deployer - #8117
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8117 +/- ##
==========================================
- Coverage 70.48% 66.22% -4.27%
==========================================
Files 515 599 +84
Lines 23150 29339 +6189
==========================================
+ Hits 16317 19429 +3112
- Misses 5776 8453 +2677
- Partials 1057 1457 +400
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
renzodavid9
force-pushed
the
issue-8041
branch
5 times, most recently
from
November 22, 2022 20:39
89793c4 to
b08ed24
Compare
renzodavid9
requested review from
a team and
tejal29
and removed request for
a team
November 23, 2022 14:45
renzodavid9
marked this pull request as ready for review
November 23, 2022 16:29
renzodavid9
force-pushed
the
issue-8041
branch
from
November 24, 2022 15:19
b08ed24 to
effb847
Compare
…ployer is used + remove not used function
renzodavid9
force-pushed
the
issue-8041
branch
from
November 28, 2022 19:25
effb847 to
de94ba1
Compare
| return false, schema.GroupVersionResource{}, fmt.Errorf("could not find resource for %s", gvk.String()) | ||
| } | ||
|
|
||
| func GetManifestsFromHydrationDir(ctx context.Context, opts config.SkaffoldOptions) (manifest.ManifestList, error) { |
aaron-prindle
pushed a commit
to aaron-prindle/skaffold
that referenced
this pull request
Dec 20, 2022
…ployer (GoogleContainerTools#8117) * fix: new condition to create hydrate-dir only if a kpt renderer or deployer is used + remove not used function * test: add integration test for new condition about hydration directory creation * test: mark integration test to run on GCP * feat: install kpt for linux integration tests * fix: making kpt hydration folder tests to run without GCP again * fix: integration-linux.yaml template for kpt installation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8041
Description
This PR adds an extra condition before creating the
hydration-dir, so it is created only when kpt is used (as renderer, deployer, or both).