Skip to content

fix: remove kubecontext check warning from kubectl deploy - #8256

Merged
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:fix-7972-v2
Dec 19, 2022
Merged

fix: remove kubecontext check warning from kubectl deploy#8256
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:fix-7972-v2

Conversation

@aaron-prindle

@aaron-prindle aaron-prindle commented Dec 18, 2022

Copy link
Copy Markdown
Contributor

fixes #7972

The error message produced here has confused-users/cluttered-their-logs (from Slack & Github feedback) and is not helpful. Removing this message to improve UX here

@codecov

codecov Bot commented Dec 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #8256 (e044247) into main (290280e) will decrease coverage by 4.37%.
The diff coverage is 54.68%.

@@            Coverage Diff             @@
##             main    #8256      +/-   ##
==========================================
- Coverage   70.48%   66.10%   -4.38%     
==========================================
  Files         515      601      +86     
  Lines       23150    29491    +6341     
==========================================
+ Hits        16317    19495    +3178     
- Misses       5776     8533    +2757     
- Partials     1057     1463     +406     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 406 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz
ericzzzzzzz merged commit a00ef25 into GoogleContainerTools:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy might not work properly warning while building an image

2 participants