Skip to content

fix: resolve issue where skaffold would not add digest when using helm in v1 -> v2 migration case - #8269

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:fix-8263
Dec 21, 2022
Merged

fix: resolve issue where skaffold would not add digest when using helm in v1 -> v2 migration case#8269
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:fix-8263

Conversation

@aaron-prindle

@aaron-prindle aaron-prindle commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

fixes #8263

requirement for v2.0.4

@codecov

codecov Bot commented Dec 21, 2022

Copy link
Copy Markdown

Codecov Report

Merging #8269 (e2877bc) into main (290280e) will decrease coverage by 4.38%.
The diff coverage is 54.68%.

❗ Current head e2877bc differs from pull request most recent head fc6c2c5. Consider uploading reports for the commit fc6c2c5 to get more accurate results

@@            Coverage Diff             @@
##             main    #8269      +/-   ##
==========================================
- Coverage   70.48%   66.09%   -4.39%     
==========================================
  Files         515      601      +86     
  Lines       23150    29491    +6341     
==========================================
+ Hits        16317    19493    +3176     
- Misses       5776     8534    +2758     
- Partials     1057     1464     +407     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 406 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle
aaron-prindle force-pushed the fix-8263 branch 5 times, most recently from 1f965cd to e2877bc Compare December 21, 2022 04:51
@aaron-prindle
aaron-prindle force-pushed the fix-8263 branch 3 times, most recently from a9cfb67 to 48c69c5 Compare December 21, 2022 06:13
@aaron-prindle
aaron-prindle merged commit 1f2de92 into GoogleContainerTools:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[regression] Skaffold v2 Helm render & deployer do not have the exact same image: value added. v2 is repo+tag whereas v1 was repo+tag+digest

2 participants