feat: allow specifying debug runtime in skaffold.yaml for artifact - #8295
Merged
Conversation
gsquared94
requested review from
aaron-prindle
and removed request for
briandealwis
January 4, 2023 11:09
Codecov Report
@@ Coverage Diff @@
## main #8295 +/- ##
==========================================
- Coverage 70.48% 66.06% -4.43%
==========================================
Files 515 603 +88
Lines 23150 29556 +6406
==========================================
+ Hits 16317 19525 +3208
- Misses 5776 8567 +2791
- Partials 1057 1464 +407
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Seems there is gofmt errors: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2203
Description
Allow specifying the debug runtime for artifacts in
skaffold.yaml.Testing instructions
In the
integration/examples/getting-startedproject:ENV GOTRACEBACK=single).skaffold debug -v DEBUG.Image "getting-started" not configured for debugging: unable to determine runtime. This implies that Skaffold couldn't identify the language runtime for this artifact for debug.skaffold.yamlfile to:skaffold debug -v DEBUGagain.Artifact "skaffold-example" has Go runtime: specified by user in skaffold config. This implies that Skaffold was able to identify Golang as the language runtime for this artifact for debug.