Skip to content

fix: move verify schema changes to v4beta4 and remove it from already released v4beta3 - #8514

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:move-verify-schema-v2
Mar 9, 2023
Merged

fix: move verify schema changes to v4beta4 and remove it from already released v4beta3#8514
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:move-verify-schema-v2

Conversation

@aaron-prindle

Copy link
Copy Markdown
Contributor

No description provided.

@aaron-prindle
aaron-prindle marked this pull request as ready for review March 8, 2023 23:51
@aaron-prindle
aaron-prindle force-pushed the move-verify-schema-v2 branch from 79a224d to 19ed39b Compare March 9, 2023 00:08
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Mar 9, 2023
@codecov

codecov Bot commented Mar 9, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8514 (19ed39b) into main (290280e) will decrease coverage by 6.12%.
The diff coverage is 54.84%.

❗ Current head 19ed39b differs from pull request most recent head aa7819a. Consider uploading reports for the commit aa7819a to get more accurate results

@@            Coverage Diff             @@
##             main    #8514      +/-   ##
==========================================
- Coverage   70.48%   64.36%   -6.12%     
==========================================
  Files         515      607      +92     
  Lines       23150    30399    +7249     
==========================================
+ Hits        16317    19566    +3249     
- Misses       5776     9368    +3592     
- Partials     1057     1465     +408     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 431 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gsquared94 gsquared94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying that failing tests are expected here. LGTM!

@aaron-prindle
aaron-prindle force-pushed the move-verify-schema-v2 branch 2 times, most recently from a1efc75 to 98c325c Compare March 9, 2023 16:39
@aaron-prindle
aaron-prindle force-pushed the move-verify-schema-v2 branch from 98c325c to aa7819a Compare March 9, 2023 16:42
@aaron-prindle aaron-prindle added the kokoro:force-run forces a kokoro re-run on a PR label Mar 9, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 9, 2023
@aaron-prindle
aaron-prindle merged commit e74ef33 into GoogleContainerTools:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants