Skip to content

chore: Add output flag for diagnose - #8546

Merged
aaron-prindle merged 3 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:add-output-flag-for-diagnose
Mar 13, 2023
Merged

chore: Add output flag for diagnose#8546
aaron-prindle merged 3 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:add-output-flag-for-diagnose

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Fixes: #8456

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle

aaron-prindle commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

@ericzzzzzzz my only concern here is maybe we should talk to internal partners to make sure putting all of the output in in the --output file is ok vs only the yaml (right now I believe diagnose outputs some additional text in a header which I'm not sure is desirable )

EDIT: nevermind, I remember there is a --yaml-only flag so I think this should be ok

@aaron-prindle
aaron-prindle merged commit 74ef9ce into GoogleContainerTools:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --output flag to skaffold diagnose flag options

2 participants