fix: logic to interrupt a k8sjob logs as soon as it fails (#8847) - #8871
Merged
renzodavid9 merged 1 commit intoJun 9, 2023
Merged
Conversation
renzodavid9
force-pushed
the
cherry-pick-k8s-ca-issue
branch
from
June 8, 2023 20:21
96be367 to
82b507d
Compare
Codecov Report
@@ Coverage Diff @@
## release/v2.5 #8871 +/- ##
===============================================
Coverage ? 63.93%
===============================================
Files ? 620
Lines ? 31460
Branches ? 0
===============================================
Hits ? 20115
Misses ? 9842
Partials ? 1503 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ainerTools#8847) * fix: logic to interrupt a k8sjob logs as soon as it fails and change in delete order, now the job is deleted before its pods * test: integration tests to check when a log should not appear in the output (cherry picked from commit c7c72a1)
renzodavid9
force-pushed
the
cherry-pick-k8s-ca-issue
branch
from
June 9, 2023 16:57
76d6532 to
4020378
Compare
renzodavid9
marked this pull request as ready for review
June 9, 2023 17:44
ericzzzzzzz
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry pick to fix #8839 in
v2.5: