Migrate optimization DSL - #378
Merged
Merged
Conversation
https://developer.android.com/topic/performance/app-optimization/enable-app-optimization#enable ```diff λ diff configuration-old.txt configuration-new.txt 93,117d92 < # The proguard configuration file for the following section is /Users/goooler/StudioProjects/Tabby/androidApp/proguard-rules.pro < -verbose < -allowaccessmodification < < -keepattributes SourceFile, < LineNumberTable < < -renamesourcefileattribute SourceFile < < -dontobfuscate < < # Remove some Kotlin overhead < -processkotlinnullchecks remove < < < # Hardcode in core/src/main/cpp/main.c.JNI_OnLoad < -keep class kotlin.Unit < -keep interface kotlinx.coroutines.CompletableDeferred < < # https://developer.android.com/reference/kotlin/androidx/compose/runtime/ComposeRuntimeFlags#isLinkBufferComposerEnabled() < -assumevalues public class androidx.compose.runtime.ComposeRuntimeFlags { < static boolean isLinkBufferComposerEnabled return true; < } < < # End of content from /Users/goooler/StudioProjects/Tabby/androidApp/proguard-rules.pro 1320a1296,1320 > # The proguard configuration file for the following section is Local project :androidApp::androidApp (extracted file: /Users/goooler/StudioProjects/Tabby/androidApp/src/main/keepRules/proguard-rules.keep) > -verbose > -allowaccessmodification > > -keepattributes SourceFile, > LineNumberTable > > -renamesourcefileattribute SourceFile > > -dontobfuscate > > # Remove some Kotlin overhead > -processkotlinnullchecks remove > > > # Hardcode in core/src/main/cpp/main.c.JNI_OnLoad > -keep class kotlin.Unit > -keep interface kotlinx.coroutines.CompletableDeferred > > # https://developer.android.com/reference/kotlin/androidx/compose/runtime/ComposeRuntimeFlags#isLinkBufferComposerEnabled() > -assumevalues public class androidx.compose.runtime.ComposeRuntimeFlags { > static boolean isLinkBufferComposerEnabled return true; > } > > # End of content from Local project :androidApp::androidApp (extracted file: /Users/goooler/StudioProjects/Tabby/androidApp/src/main/keepRules/proguard-rules.keep) ```
Owner
Author
|
There was a problem hiding this comment.
Pull request overview
Migrates the Android release build configuration from the legacy minifyEnabled/shrinkResources/proguardFiles setup to the newer optimization { enable = true } DSL, and relocates the R8/ProGuard rules into the src/main/keepRules source set.
Changes:
- Switched the
releasebuild type to useoptimization { enable = true }instead of the legacy shrinking configuration. - Added
androidApp/src/main/keepRules/proguard-rules.keepcontaining the project’s R8/ProGuard configuration previously embedded in the old pipeline.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| androidApp/src/main/keepRules/proguard-rules.keep | Introduces keep/assumevalues rules under the new keepRules source set. |
| androidApp/build.gradle.kts | Updates release build type to use the optimization DSL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://developer.android.com/topic/performance/app-optimization/enable-app-optimization#enable