Use the non-deprecated depends_on macos symbol form#16
Merged
Conversation
Homebrew deprecated the string-comparison form (">= :sonoma") for
depends_on macos in favor of the bare symbol form, which carries the
same "Sonoma or newer" meaning.
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: GitButler <gitbutler@gitbutler.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
Updates the Homebrew Cask DSL snippet generated in the build workflow to use the newer depends_on macos syntax, replacing the deprecated string-comparison form with the bare macOS symbol.
Changes:
- Replace
depends_on macos: ">= :sonoma"withdepends_on macos: :sonomain the generated cask definition within the workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew deprecated the string-comparison form for
depends_on macosin the cask DSL. This swaps">= :sonoma"for the bare symbol:sonoma, which carries the same meaning (Sonoma or newer) using the current, non-deprecated syntax.Test plan
depends_on macosline in.github/workflows/build.ymlbefore and after the change