Fix heredoc terminator in create-release skill#19
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesRelease notes template
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the release creation instructions in SKILL.md by using quadruple backticks to properly nest a triple-backtick code block and unindenting the bash commands. The reviewer suggested an improvement to use the native --notes-file - option of the GitHub CLI to pass multiline release notes, which is cleaner and avoids nesting command substitutions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
This PR fixes a documentation issue in the create-release skill where a Bash heredoc terminator (EOF) could be indented when copy-pasted, preventing the heredoc from closing correctly and corrupting the gh release create --notes content.
Changes:
- Dedented the
gh release create ... --notes "$(cat <<'EOF' ... EOF)"block so theEOFterminator is at column 0 for correct heredoc closure when copy-pasted. - Switched the outer fenced block to four backticks to safely include a nested triple-backtick
bashblock inside the release notes template.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
The
gh release createblock in.claude/skills/create-release/SKILL.mdwas indented under the numbered list, which put the closingEOF(and the whole--notes "$(cat <<'EOF' … EOF)"body) at a non-zero column. Bash only treats a<<'EOF'heredoc as closed when the terminator line has no leading whitespace, so a literal copy-paste of that command wouldn't close the heredoc — it would swallow theEOFline and corrupt the release notes.Fixed by dedenting the release block to column 0 and switching the outer fence to four backticks (so the nested
```bashinstall block doesn't close it early), matching the already-correctideandPullUpcreate-release skills. Terminator now sits at column 0.Test plan
grep -n '^EOF$'confirms the terminator is at column 0.Summary by CodeRabbit