fix(Daedalus): fix member registration for G2 classic#116
Merged
Conversation
G2 exclusive class members for `C_NPC` and `C_ITEM` are currently registered based on a check if `effect` exists as member. Problem is this is the only member that didn't exist in G2 classic but was later introduced in the Addon. Add a separate check for `effect` to have other members properly registered in case G2 classic is used. Reported as bug in Try/OpenGothic#840.
Member
|
Heyo, thank you for the fix! Looks good to me, so I'll merge it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G2 exclusive class members for
C_NPCandC_ITEMare currently registered based on a check ifeffectexists as member.Problem is this is the only member that didn't exist in G2 classic but was later introduced in the Addon. Add a separate check for
effectto have other members properly registered in case G2 classic is used.Reported as bug in Try/OpenGothic#840.