security: hash API keys with HMAC-SHA256, never store plaintext#12
Merged
Merged
Conversation
…ompare plaintext - APIKey model: replace plaintext `key` column with `key_hash` + `key_prefix` - auth.py: hash incoming key before DB lookup, eliminating plaintext comparison - key_utils.py: generate_api_key(), hash_api_key(), constant_time_compare() - KEY_HMAC_SECRET env var required at runtime Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API keys were stored in plaintext in the database and compared directly. A DB breach would expose all active keys.
Changes:
APIKeymodel:keycolumn replaced withkey_hash(HMAC-SHA256) +key_prefix(first 8 chars for display)auth.py: incoming key is hashed before lookup — no plaintext ever touches the DBkey_utils.py:generate_api_key(),hash_api_key(),constant_time_compare()helpersRequired new env var
Migration note
Existing keys in local SQLite will stop working (schema change). Re-create any test API keys after applying. For staging/production, a migration script is needed to hash existing plaintext keys — coordinate with Lambda before deploying.
Test plan
🤖 Generated with Claude Code