fix(auth): load KEY_HMAC_SECRET via pydantic settings#22
Merged
Conversation
…nviron at import time
Refs: dad49415-dc61-41a5-b1c6-a013d156ee0a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KEY_HMAC_SECRETwas read fromos.environat module import time inkey_utils.py, before pydantic-settings had a chance to load.envRuntimeErroron any authenticated endpoint when running locallykey_hmac_secretinto theSettingsmodel (pydantic-settings loads it correctly from.envor env vars), read it lazily per-call in_hmac_secret()Test
x-request-idandx-response-time-msheaders present ✅