chore: gitignore cloud/ + sdk/ orphans from #76 split#87
Merged
Conversation
Both dirs were removed from the repo when cloud/ + marketing/ moved to private Gradata/gradata-cloud (#76), but the files remain on local checkouts. Gitignoring stops the churn in git status. Co-Authored-By: Gradata <noreply@gradata.ai>
Deploying gradata-dashboard with
|
| Latest commit: |
7ff498a
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gradata has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Caution Review failedPull request was closed or merged during review 📝 Walkthrough
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Gradata
added a commit
that referenced
this pull request
Apr 15, 2026
#88 landed at the same time as #86 and #87 shipping from a parallel session. The merges didn't conflict line-wise, but the diffs overlap: - brain.py:apply_brain_rules — #86 already wired `rules.injected` with a richer payload (id + category + confidence + state + scope) and try/except guard. #88 added a second thinner emit after the cache.put. Result: double-fire on fresh compute. Harmless in practice — SessionHistory dedups via a set — but clearly wrong. Removing #88's emit, keeping #86's. - .gitignore — #87 already added `/cloud/` and `/sdk/`. #88's re-adds are duplicates. Removing; keeping `/railway.toml` and `apollo-leads-*.csv` which are genuinely new from #88. The regression test in tests/test_session_history.py stays — it asserts the emit fires end-to-end from a real Brain + correct() loop, complementing #86's test_wiring_compound.py coverage of payload shape. Both pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Gradata
added a commit
that referenced
this pull request
Apr 15, 2026
#88 landed at the same time as #86 and #87 shipping from a parallel session. The merges didn't conflict line-wise, but the diffs overlap: - brain.py:apply_brain_rules — #86 already wired `rules.injected` with a richer payload (id + category + confidence + state + scope) and try/except guard. #88 added a second thinner emit after the cache.put. Result: double-fire on fresh compute. Harmless in practice — SessionHistory dedups via a set — but clearly wrong. Removing #88's emit, keeping #86's. - .gitignore — #87 already added `/cloud/` and `/sdk/`. #88's re-adds are duplicates. Removing; keeping `/railway.toml` and `apollo-leads-*.csv` which are genuinely new from #88. The regression test in tests/test_session_history.py stays — it asserts the emit fires end-to-end from a real Brain + correct() loop, complementing #86's test_wiring_compound.py coverage of payload shape. Both pass. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line hygiene. Both dirs were removed from this repo by PR #76 (cloud split to private Gradata/gradata-cloud) but files remain on local working copies. Adding to `.gitignore` stops them cluttering `git status`.
Co-Authored-By: Gradata noreply@gradata.ai