chore: wire dormant rules.injected emit + gitignore S105 orphans

[Gradata]

Follow-ups to the Railway fix (gradata-cloud#1, #2, 54f2841 direct-to-main) — the (b) and (c) in our audit plan.

(c) Wire dormant rules.injected emit

integrations/session_history.py subscribes to three events:

• correction.created — emitted at _core.py:138, 574
• session.ended — emitted at _core.py:854
• rules.injected — zero emitters anywhere in the tree

Result: SessionHistory.compute_effectiveness() is silently dead. Rules get injected every call but nothing records which ones, so per-session effectiveness tracking never runs.

Fix: brain.apply_brain_rules() now emits rules.injected on the in-memory bus after format_rules_for_prompt(applied). Cache hits skip intentionally — SessionHistory dedups via a set, the rule cache is per-scope, fresh scopes hit the compute path.

(b) Gitignore on-disk orphans

• /cloud/ — moved to private Gradata/gradata-cloud in chore: split cloud/ and marketing/ to private gradata-cloud #76
• /sdk/ — superseded by the flat layout in chore: senior-dev polish pass on repo root #65
• /railway.toml — now lives in gradata-cloud/cloud/railway.toml
• apollo-leads-*.csv

Tests

• tests/test_session_history.py — 7 pass (1 new)
• test_loop_and_security, test_integrations, test_nervous_system_integration — 64 pass

Follow-ups not here

• Publish gradata 0.5.0 to PyPI so gradata-cloud can drop the SHA-tarball pin
• ~2000 LOC dead-code prune — deferred as its own initiative
• Physically delete the three orphan dirs on disk (gitignore only stops them recurring)

🤖 Generated with Claude Code

[greptile-apps]

Gradata has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4629a465-397a-4911-9b1f-23774bc3f9a8

📥 Commits

Reviewing files that changed from the base of the PR and between 81743f2 and 3ad836b.

📒 Files selected for processing (3)

• .gitignore
• src/gradata/brain.py
• tests/test_session_history.py

---

📝 Walkthrough

• Wire dormant rules.injected emit: brain.apply_brain_rules() now emits a rules.injected event on the in-memory bus after formatting applied rules; cache hits intentionally skip the emit, enabling proper rule-effectiveness tracking in SessionHistory
• Add regression test: New test test_apply_brain_rules_emits_rules_injected verifies that SessionHistory observes injected rules when apply_brain_rules() is called with real corrections
• Gitignore orphaned artifacts: Added entries to .gitignore for /cloud/, /sdk/, /railway.toml, and apollo-leads-*.csv to prevent recurring on-disk remnants from repository splits
• No breaking changes, public API additions, or security fixes included
• All tests passing: 7 tests in test_session_history.py (including 1 new) and 64 tests across other test groups

Walkthrough

The changes add event emission to rule application in the Brain class when rules are successfully applied, update gitignore to exclude additional orphaned artifacts and stale config files, and introduce a regression test to verify the new event is properly emitted and observed by SessionHistory.

Changes

Cohort / File(s)	Summary
Gitignore Configuration .gitignore	Added ignore rules for orphaned directories (cloud/, sdk/), stale configuration (railway.toml), and sales export files (apollo-leads-*.csv).
Event Emission on Rule Application src/gradata/brain.py	apply_brain_rules() now emits a "rules.injected" event to the in-memory bus with rule IDs and task context when rules are successfully applied, excluding cached rule hits.
Regression Test tests/test_session_history.py	Added test verifying that SessionHistory correctly observes the "rules.injected" event emitted by Brain when apply_brain_rules() is called, confirming end-to-end event integration.

Sequence Diagram

sequenceDiagram
    participant Test
    participant Brain
    participant Bus
    participant SessionHistory
    
    Test->>Brain: apply_brain_rules("write an email")
    activate Brain
    Brain->>Brain: format & apply rules
    Note over Brain: applied is non-empty
    Brain->>Bus: emit("rules.injected",<br/>{"rules": [...], "task": ...})
    deactivate Brain
    Bus->>SessionHistory: rules.injected event
    activate SessionHistory
    SessionHistory->>SessionHistory: update injected_this_session
    deactivate SessionHistory
    Test->>SessionHistory: assert injected_this_session<br/>has rule IDs
    SessionHistory-->>Test: ✓ verified

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

bug

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/gracious-euclid

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}