Validate username and password early#104
Merged
martinbonnin merged 3 commits intomainfrom Jun 25, 2025
Merged
Conversation
vlsi
reviewed
Jun 25, 2025
vlsi
reviewed
Jun 25, 2025
Comment on lines
+120
to
+105
| check(centralPortalOptions.username.isPresent) { | ||
| "Nmcp: username is missing" | ||
| } | ||
| check(centralPortalOptions.password.isPresent) { | ||
| "Nmcp: password is missing" | ||
| } |
Contributor
There was a problem hiding this comment.
All the validations should better be reported, not just one of them
Member
Author
There was a problem hiding this comment.
We can check publishingType is one of AUTOMATIC | USER_MANAGED. Anything else?
martinbonnin
force-pushed
the
validate-username-password
branch
from
df18a82 to
29f37b4
Compare
use taskGraph.whenReady {}
# Conflicts:
# src/main/kotlin/nmcp/internal/DefaultNmcpExtension.kt
# src/main/kotlin/nmcp/internal/utils.kt
# Conflicts:
# src/main/kotlin/nmcp/internal/DefaultNmcpExtension.kt
martinbonnin
force-pushed
the
validate-username-password
branch
from
29f37b4 to
554b1fa
Compare
Member
Author
|
Merging this as is for now. Will revisit to add more validations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #103