Refactor the AAR-detection#2118
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the AAR-detection logic used by ShadowJar when adding included dependencies, simplifying the conditional while keeping the same effective behavior (detect AARs and fail with a clear message).
Changes:
- Replaces the
File.isAar()extension function with aFile.isAarextension property. - Moves the
.aarextension check inside the AAR-detection logic and simplifies thewhenbranch tofile.isAar.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Goooler
commented
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.