Optimize normalizeJar memory footprint and preserve entry metadata

[Goooler]

No description provided.

[Copilot]

Pull request overview

This PR improves the post-R8 jar “normalization” step so Shadow can rewrite R8’s output jar while preserving important entry metadata and avoiding loading entire entry contents into memory.

Changes:

• Rework R8Minimizer.normalizeJar to stream entry bytes from the input zip instead of materializing them, and preserve each entry’s Unix mode.
• Ensure META-INF/MANIFEST.MF is written as the first file entry in the normalized jar.
• Add a focused regression test validating manifest ordering and executable permissions preservation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/R8MinimizerTest.kt	Adds coverage for manifest-first ordering and Unix mode preservation during normalization.
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/Zip.kt	Adds UnixMode.raw(...) to allow writing preserved Unix modes verbatim.
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/R8Minimizer.kt	Streams jar normalization, preserves Unix permissions, and forces manifest to be first file entry.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.kt:139

• ShadowCopyAction still accepts an encoding parameter, but the StreamAction no longer applies it to the provided ZipOutputStream. This makes the encoding argument ineffective for callers that provide a custom zosProvider, which is a behavioral/API regression.

  private inner class StreamAction(private val zipOutStr: ZipOutputStream) :
    CopyActionProcessingStreamAction {
    init {
      logger.info("Relocator count: {}.", relocators.size)
    }

src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/R8MinimizerTest.kt:71

• The test will currently fail with an NPE if the entry is missing, which obscures the cause. Adding an explicit null check gives a clearer failure message.

    ZipFile(outputJar).use { zipFile ->
      // Executable unix mode must be preserved
      val scriptEntry = zipFile.getEntry("bin/script.sh")
      assertThat(scriptEntry.unixMode).isEqualTo(expectedExecutableMode)
    }