Skip to content

🔒 Fix Personal Access Token exposure in runner-self-test.sh#1191

Merged
GrammaTonic merged 2 commits into
developfrom
security/fix-token-exposure-runner-self-test-7830841904974959260
Mar 17, 2026
Merged

🔒 Fix Personal Access Token exposure in runner-self-test.sh#1191
GrammaTonic merged 2 commits into
developfrom
security/fix-token-exposure-runner-self-test-7830841904974959260

Conversation

@GrammaTonic
Copy link
Copy Markdown
Owner

🎯 What: The vulnerability fixed

Exposure of Personal Access Token (GH_PAT) in CLI history and process listings.

⚠️ Risk: The potential impact if left unfixed

An attacker with access to the system could view the token by listing running processes (e.g., ps aux) or by inspecting command history if the script was executed manually. This token could then be used to gain unauthorized access to the GitHub repository.

🛡️ Solution: How the fix addresses the vulnerability

The fix uses curl's --config - (or -K-) option to read headers from standard input. By using printf (a shell builtin) to pipe the Authorization header directly into curl, the secret token never appears as an argument to the curl process, thus keeping it out of process listings and command history.

A new test script tests/security/verify-curl-fix.sh has been added to verify that the token is correctly transmitted in headers while remaining hidden from the process list.


PR created automatically by Jules for task 7830841904974959260 started by @GrammaTonic

Modified `scripts/runner-self-test.sh` to pass the GitHub Personal Access Token (`GH_PAT`) to `curl` via stdin using the `-K-` option. This prevents the token from appearing in process listings or command history, addressing a security vulnerability.

Changes:
- Replaced direct `-H "Authorization: token $GH_PAT"` with a piped configuration using `printf` and `curl -K-`.
- Added a security verification test in `tests/security/verify-curl-fix.sh`.

Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical security vulnerability by preventing the exposure of GitHub Personal Access Tokens (GH_PAT) in system process listings and command history. By refactoring how the curl command handles authentication headers, sensitive credentials are now securely passed, significantly reducing the risk of unauthorized access to GitHub resources. A dedicated test script has also been added to ensure the effectiveness of this security enhancement.

Highlights

  • Security Vulnerability Fix: Addressed the exposure of Personal Access Tokens (GH_PAT) in CLI history and process listings, preventing unauthorized access to GitHub repositories.
  • Secure Token Handling: Implemented a fix using printf to pipe the Authorization header directly into curl via the -K- option, ensuring the token never appears as a command-line argument.
  • New Security Test: Introduced tests/security/verify-curl-fix.sh to validate that the token is correctly transmitted in headers while remaining hidden from the process list.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • scripts/runner-self-test.sh
    • Updated the check_runner_registered function to use printf and curl -K- for secure GH_PAT handling.
  • tests/security/verify-curl-fix.sh
    • Added a new script to verify the secure transmission of tokens and their absence from process lists.
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a critical security vulnerability by preventing the GH_PAT from being exposed in the process list and command history. The method of piping the Authorization header to curl using the -K- option is an effective and appropriate fix. The addition of a verification script is also a great step. I have one suggestion for the new test script to make it more robust by eliminating a potential race condition, which will ensure the test reliably verifies the fix.

Comment thread tests/security/verify-curl-fix.sh Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@GrammaTonic GrammaTonic merged commit 7b74da6 into develop Mar 17, 2026
18 checks passed
@GrammaTonic GrammaTonic deleted the security/fix-token-exposure-runner-self-test-7830841904974959260 branch March 17, 2026 17:05
GrammaTonic added a commit that referenced this pull request Mar 17, 2026
* chore(deps): chore(deps)(deps): bump actions/cache from 4 to 5

Automatically merged Dependabot PR after CI validation.

* chore(deps): chore(deps)(deps): bump trufflesecurity/trufflehog from 3.93.7 to 3.93.8

Automatically merged Dependabot PR after CI validation.

* chore(deps): chore(deps)(deps): bump docker/metadata-action from 5 to 6

Automatically merged Dependabot PR after CI validation.

* 🔒 Fix Personal Access Token exposure in runner-self-test.sh (#1191)

* 🔒 fix: prevent Personal Access Token exposure in CLI history

Modified `scripts/runner-self-test.sh` to pass the GitHub Personal Access Token (`GH_PAT`) to `curl` via stdin using the `-K-` option. This prevents the token from appearing in process listings or command history, addressing a security vulnerability.

Changes:
- Replaced direct `-H "Authorization: token $GH_PAT"` with a piped configuration using `printf` and `curl -K-`.
- Added a security verification test in `tests/security/verify-curl-fix.sh`.

Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>

* Update tests/security/verify-curl-fix.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* 🔒 Fix Command Injection in Deploy Script via Unescaped Hostname (#1193)

* 🔒 Fix command injection vulnerability in deploy script

Added container name validation and improved docker command security
by using the -- delimiter to prevent option injection.

- Added `validate_container_name` function to enforce Docker naming conventions.
- Updated `health_check` and `show_status` functions in `scripts/deploy.sh`
  to validate container names before use and use `--` in Docker commands.

Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>

* Update scripts/deploy.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update scripts/deploy.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update scripts/deploy.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* 🔒 fix(security): sanitize job name in file paths to prevent traversal (#1192)

* fix(security): sanitize job name in file paths

Mitigate path traversal vulnerability by sanitizing GITHUB_JOB before
using it in file paths in job-started.sh and job-completed.sh.
Introduced a sanitize_name function in utils.sh to replace unsafe
characters with underscores. Updated unit tests accordingly.

Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>

* Update tests/unit/test-job-started.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update docker/utils.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* feat: enforce Node.js 24 for all runners and workflows (#1190)

* feat: enforce Node.js 24 for all runners via FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var

- Adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true to all runner Docker Compose files
- Documents the variable in all example .env files
- Ensures all JavaScript actions use Node.js 24 across standard, Chrome, and Chrome-Go runners

See #performance, #devops, #nodejs, #ci-cd

* chore: enforce Node.js 24 for all actions in ci-cd workflow via FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var

---------

Co-authored-by: rr <rr>

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
GrammaTonic added a commit that referenced this pull request Mar 17, 2026
* chore(deps): chore(deps)(deps): bump actions/cache from 4 to 5

Automatically merged Dependabot PR after CI validation.

* chore(deps): chore(deps)(deps): bump trufflesecurity/trufflehog from 3.93.7 to 3.93.8

Automatically merged Dependabot PR after CI validation.

* chore(deps): chore(deps)(deps): bump docker/metadata-action from 5 to 6

Automatically merged Dependabot PR after CI validation.

* 🔒 Fix Personal Access Token exposure in runner-self-test.sh (#1191)

* 🔒 fix: prevent Personal Access Token exposure in CLI history

Modified `scripts/runner-self-test.sh` to pass the GitHub Personal Access Token (`GH_PAT`) to `curl` via stdin using the `-K-` option. This prevents the token from appearing in process listings or command history, addressing a security vulnerability.

Changes:
- Replaced direct `-H "Authorization: token $GH_PAT"` with a piped configuration using `printf` and `curl -K-`.
- Added a security verification test in `tests/security/verify-curl-fix.sh`.

Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>

* Update tests/security/verify-curl-fix.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* 🔒 Fix Command Injection in Deploy Script via Unescaped Hostname (#1193)

* 🔒 Fix command injection vulnerability in deploy script

Added container name validation and improved docker command security
by using the -- delimiter to prevent option injection.

- Added `validate_container_name` function to enforce Docker naming conventions.
- Updated `health_check` and `show_status` functions in `scripts/deploy.sh`
  to validate container names before use and use `--` in Docker commands.

Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>

* Update scripts/deploy.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update scripts/deploy.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update scripts/deploy.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* 🔒 fix(security): sanitize job name in file paths to prevent traversal (#1192)

* fix(security): sanitize job name in file paths

Mitigate path traversal vulnerability by sanitizing GITHUB_JOB before
using it in file paths in job-started.sh and job-completed.sh.
Introduced a sanitize_name function in utils.sh to replace unsafe
characters with underscores. Updated unit tests accordingly.

Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>

* Update tests/unit/test-job-started.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update docker/utils.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* feat: enforce Node.js 24 for all runners and workflows (#1190)

* feat: enforce Node.js 24 for all runners via FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var

- Adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true to all runner Docker Compose files
- Documents the variable in all example .env files
- Ensures all JavaScript actions use Node.js 24 across standard, Chrome, and Chrome-Go runners

See #performance, #devops, #nodejs, #ci-cd

* chore: enforce Node.js 24 for all actions in ci-cd workflow via FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var

---------

Co-authored-by: rr <rr>

* chore: update Go version to 1.25.7 across Chrome-Go runner configs, Dockerfiles, compose, and docs

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: GrammaTonic <8269379+GrammaTonic@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: rr <rr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant