🔒 Fix Command Injection in Deploy Script via Unescaped Hostname

[GrammaTonic]

This PR addresses a security vulnerability in scripts/deploy.sh where unescaped or maliciously crafted container names could lead to command or option injection.

🎯 What: The vulnerability fixed is a potential command/option injection via the $container variable in the health_check and show_status functions.
⚠️ Risk: A malicious user or a compromised environment could potentially inject Docker options by crafting container names that start with a dash or contain other unexpected characters.
🛡️ Solution:

• Implemented a validate_container_name function that ensures container names match the expected Docker format (^[a-zA-Z0-9][a-zA-Z0-9_.-]*$).
• Updated docker exec and docker stats calls to use the -- delimiter, ensuring that subsequent arguments are treated as positional arguments rather than options.
• Added explicit validation of each container name before processing in the health_check and show_status loops.

These changes follow security best practices for shell scripting and provide defense-in-depth against injection attacks.

---

PR created automatically by Jules for task 10708231991083344428 started by @GrammaTonic

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security posture of the deployment script by preventing potential command and option injection vulnerabilities. It introduces robust input validation for Docker container names and correctly utilizes command delimiters, ensuring that the script handles user-provided or environment-derived container names safely and predictably, thereby protecting against malicious manipulation.

Highlights

• Security Fix: Addressed a command injection vulnerability in scripts/deploy.sh that could occur via unescaped or maliciously crafted container names.
• Input Validation: Implemented a new validate_container_name function to ensure container names conform to expected Docker naming conventions, preventing injection attempts.
• Command Delimiter Usage: Updated docker exec and docker stats commands to use the -- delimiter, explicitly separating options from positional arguments and mitigating option injection.
• Explicit Validation: Integrated explicit validation of container names within the health_check and show_status loops, skipping invalid names with a warning.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• scripts/deploy.sh
  • Added validate_container_name function to check for valid Docker container name format.
  • Modified show_status function to validate container names before passing them to docker stats and used the -- delimiter.
  • Modified health_check function to validate container names and use the -- delimiter for docker exec commands.

Activity

• PR created automatically by Jules for task 10708231991083344428, started by @GrammaTonic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a command injection vulnerability in the deploy script. The use of a validation function for container names and the -- delimiter in docker commands are excellent security measures. My review includes a few suggestions to further improve the script's efficiency and robustness by using shell scripting best practices, such as using arrays for lists of arguments and preferring built-in operators over external commands.