chore(web): dedupe LOD_THRESHOLDS + document the web/UI architecture - #88
Merged
Conversation
Scrub of the last day's UI work: - Remove the shadowed/dead module-level LOD_THRESHOLDS in IGV; keep a single source of truth carrying the values the graph actually ran on (behavior- identical) and drop the unused MEDIUM/VERY_CLOSE keys. - Drop leftover console.log diagnostics from the node-expand-legibility spec (the assertion messages already carry the values). - New docs/guides/web-ui-architecture.md: a concise component diagram + notes for the view system, graph canvas, mobile shell, and node inspector — the client layer the existing (server-focused) architecture-overview.md didn't cover. Linked from architecture-overview.md + docs/README.md. No behavior change: typecheck + lint clean, smoke 5/5, node-inspector + node-expand-legibility diagnostics green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrub + docs pass over the last day's UI work (no behavior change).
Code scrub
LOD_THRESHOLDSshadowed by an inner duplicate with different values; every usage resolved to the inner one, so the module-level was dead. Consolidated to a single source of truth holding the live values (behavior-identical), dropped the unusedMEDIUM/VERY_CLOSEkeys.console.logdiagnostics fromnode-expand-legibility.spec.ts(values moved into the assertion messages).Docs
docs/guides/web-ui-architecture.md(one mermaid component diagram) documenting the client layer the server-focusedarchitecture-overview.mdnever covered: view system, graph canvas, mobile shell, node inspector/expand/legibility, mobile-audit gate. Linked fromarchitecture-overview.md+docs/README.md.Verified locally: typecheck ✓, lint 0 errors, smoke 5/5, node-inspector + node-expand-legibility diagnostics 3/3.
🤖 Generated with Claude Code