Apply private-file check to shared text content URIs#135
Merged
Conversation
RankoR
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShareIntentActivity's attachment path (addSharedPartToDraft) routes shared URIs through FileUtil.isInPrivateDir, which since f1b8f9a (Bug 275552292) resolves a content:// URI to its backing file and refuses the app's own private storage. The shared text/plain path, getTextStringFromContentUri, reads the supplied content:// URI through the app's ContentResolver with no such check, so the same private files remain reachable through the shared-text surface and their contents are read into the draft.
This applies the same FileUtil.isInPrivateDir guard at the top of getTextStringFromContentUri, covering both the SEND and SEND_MULTIPLE paths. A private-directory URI is skipped (returns null) instead of read; the attachment path is unchanged.