Fix RSS feed URLs being converted incorrectly #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
I'm using an RSS feed reader and I've subscribed to the Frog Blog. However the links from the RSS feed seemed to always be incorrect, prompting me to click on the "Blog" button at the top and clicking on the article just to read it.
If we look at the feed, we can see the articles have a URL of https://graphicsprogramming.github.io/blog/article-name-here. When clicking on this link, we will get navigated to https://graphics-programming.org/article-name-here.
This fix just changes the URL in the Docusaurus config to be the actual deployment URL so that the articles in the feed have the proper URL already.
To be honest, I'm not that familiar with the current state of the blog, so maybe this change will break some convention or something that relies upon the GitHub pages URL being used, so I apologize in advanced for the lack of checks.
Hopefully this fixes RSS woes for our frogs