Skip to content

feature/footer-section#26

Merged
sebastian-noel merged 2 commits into
mainfrom
feature/footer-section
Jul 22, 2026
Merged

feature/footer-section#26
sebastian-noel merged 2 commits into
mainfrom
feature/footer-section

Conversation

@Kevinli7673

Copy link
Copy Markdown
Collaborator

Pull Request

Description

Created the footer section. All but the challenges archive link works

Type of Change

  • feat: New feature
  • fix: Bug fix
  • chore: Maintenance (dependencies, config, etc.)
  • docs: Documentation only
  • style: Code style (formatting, no logic change)
  • refactor: Code refactor (no new feature or fix)

Changes Made

  • Created the footer and the links
  • Added images for logo

Screenshots (if applicable)

Screenshot 2026-06-27 183755

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have tested my changes locally
  • npm run lint passes without errors
  • npm run build completes successfully

Related Issues

@sebastian-noel sebastian-noel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good! just some fixes

  • text-10 isn't a real Tailwind class (no 10 in the font-size scale), so the "Club/Resources/Connect" labels were silently getting no size styling, switched to text-sm.
  • The GitHub/Instagram/LinkedIn icon links had target="_blank" with no rel at all, and FooterRow's links only had rel="noreferrer". Added rel="noopener noreferrer" everywhere to match the pattern used elsewhere in the codebase
  • Switched the page.tsx import to @/components/Footer (alias, matching every other import) instead of a relative path

nothing behavioral changed beyond the rel/URL fixes, rest is just consistency with the rest of the repo.

@sebastian-noel
sebastian-noel merged commit ef2a18b into main Jul 22, 2026
2 checks passed
@sebastian-noel
sebastian-noel deleted the feature/footer-section branch July 22, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants