feature/footer-section#26
Merged
Merged
Conversation
Kevinli7673
requested review from
StevScripts,
alecocosette and
sebastian-noel
as code owners
June 27, 2026 22:38
sebastian-noel
approved these changes
Jul 22, 2026
sebastian-noel
left a comment
Member
There was a problem hiding this comment.
looks mostly good! just some fixes
- text-10 isn't a real Tailwind class (no 10 in the font-size scale), so the "Club/Resources/Connect" labels were silently getting no size styling, switched to text-sm.
- The GitHub/Instagram/LinkedIn icon links had target="_blank" with no rel at all, and FooterRow's links only had rel="noreferrer". Added rel="noopener noreferrer" everywhere to match the pattern used elsewhere in the codebase
- Switched the page.tsx import to @/components/Footer (alias, matching every other import) instead of a relative path
nothing behavioral changed beyond the rel/URL fixes, rest is just consistency with the rest of the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Created the footer section. All but the challenges archive link works
Type of Change
feat: New featurefix: Bug fixchore: Maintenance (dependencies, config, etc.)docs: Documentation onlystyle: Code style (formatting, no logic change)refactor: Code refactor (no new feature or fix)Changes Made
Screenshots (if applicable)
Checklist
npm run lintpasses without errorsnpm run buildcompletes successfullyRelated Issues