Skip to content

Fix packaged skill coverage for install targets#102

Closed
missflash wants to merge 1 commit into
Graphify-Labs:v3from
missflash:shkim_dev_260409
Closed

Fix packaged skill coverage for install targets#102
missflash wants to merge 1 commit into
Graphify-Labs:v3from
missflash:shkim_dev_260409

Conversation

@missflash

Copy link
Copy Markdown

Behavior before

  • CLI accepted newer install targets
  • package metadata did not fully include all required skill files
  • packaged installs for some supported platforms were at risk of failing with missing-file errors

Behavior after

  • all supported install targets have matching packaged skill assets
  • tests now cover the full supported install matrix exposed by the CLI
  • future regressions are more likely to be caught during test runs

Validation

Verified with:

  • python3 -m compileall graphify tests
  • direct install(platform=...) execution for:
    • claude
    • codex
    • opencode
    • claw
    • droid
    • trae
    • trae-cn
    • windows

pytest was not available in the current environment, so full test-suite execution was not run here.

Scope

This PR intentionally avoids broader refactors and only fixes the packaging/test gap needed to make supported
install targets consistent with shipped artifacts.

Copilot AI review requested due to automatic review settings April 9, 2026 00:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR closes a packaging/test gap between the CLI’s supported install(platform=...) targets and the skill markdown assets actually shipped in the Python package, reducing the chance of missing-file failures after install.

Changes:

  • Added install routing tests for additional supported platforms (droid, trae, trae-cn, windows).
  • Expanded the “all skill files exist in package” test to cover the full installable skill file set.
  • Updated setuptools package-data to include the missing packaged skill asset (skill-trae.md).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/test_install.py Adds coverage for newly supported install targets and asserts all required skill assets are present in the installed package.
pyproject.toml Ensures skill-trae.md is included in the built distribution via tool.setuptools.package-data.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

safishamsi added a commit that referenced this pull request Apr 9, 2026
…coverage, .graphify_python persistence

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
safishamsi added a commit that referenced this pull request Apr 9, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@safishamsi

Copy link
Copy Markdown
Collaborator

Applied in v0.3.18. skill-trae.md is now included in pyproject.toml package-data alongside the other skill files. The test suite also has four new install tests covering droid, trae, trae-cn, and windows, and test_all_skill_files_exist_in_package now checks all seven skill files. Thanks for catching this.

@safishamsi safishamsi closed this Apr 9, 2026
safishamsi added a commit that referenced this pull request Apr 23, 2026
…coverage, .graphify_python persistence

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
safishamsi added a commit that referenced this pull request Apr 23, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
matzls pushed a commit to matzls/graphify that referenced this pull request May 10, 2026
…y-Labs#109: extension drift, click detection, skill coverage, .graphify_python persistence

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
matzls pushed a commit to matzls/graphify that referenced this pull request May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants