fix(bash): link executed scripts across files#1778
Draft
balloon72 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Link Bash scripts that execute sibling scripts directly or through a common shell runner.
Root cause
The Bash extractor only treated
sourceand.as cross-file commands. Direct./script.shcalls and commands such asbash ./script.shwere ignored, leaving script call topology disconnected.Changes
callsedges from the current entrypoint or function to the target script entrypoint..shpaths for direct execution andbash,sh,zsh,ksh, anddashrunners.Validation
python -m pytest tests/test_extract.py -k "script_invocation" -q(6 passed)python -m pytest tests/test_extract.py -q -k "not collect_files_follows_symlinked_directory and not collect_files_skips_out_of_root_symlinked_directory and not collect_files_skips_out_of_root_symlinked_file_by_default and not collect_files_handles_circular_symlinks"(119 passed, 1 skipped)python -m py_compile graphify/extractors/bash.py tests/test_extract.pypython -m graphify update .git diff --check origin/v8...HEADThe full local suite was attempted but could not complete because Windows Store Python repeatedly crashed in existing
ProcessPoolExecutorpipeline tests. GitHub CI remains the full-suite check.Fixes #1756