fix(cache): skip non-file source_file in save_semantic_cache#444
Closed
rashikkathuria wants to merge 1 commit into
Closed
fix(cache): skip non-file source_file in save_semantic_cache#444rashikkathuria wants to merge 1 commit into
rashikkathuria wants to merge 1 commit into
Conversation
Subagent-produced semantic fragments occasionally set source_file to a directory path instead of a file (e.g. an abstract base the model attributed to a folder). save_cached then crashes on file_hash -> read_bytes with IsADirectoryError (errno 21), aborting the whole batch and leaving partial cache state. save_cached now no-ops on non-file paths; save_semantic_cache uses is_file() instead of exists() so directory entries are silently skipped. Real files in the same batch still cache normally. Adds 3 tests covering directory, missing-file, and mixed-batch cases.
safishamsi
added a commit
that referenced
this pull request
Apr 21, 2026
- cache: skip directory source_file in save_cached to prevent IsADirectoryError (#444) - report: skip structural-only communities with no real nodes (#443) - hooks: allow @ in python path allowlist for Homebrew paths (#474) - watch: keep source_file paths project-relative after rebuild (#434) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
Thanks for the detailed fix and tests! Implemented directly in v0.4.24 — the |
safishamsi
added a commit
that referenced
this pull request
Apr 23, 2026
- cache: skip directory source_file in save_cached to prevent IsADirectoryError (#444) - report: skip structural-only communities with no real nodes (#443) - hooks: allow @ in python path allowlist for Homebrew paths (#474) - watch: keep source_file paths project-relative after rebuild (#434) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
matzls
pushed a commit
to matzls/graphify
that referenced
this pull request
May 10, 2026
- cache: skip directory source_file in save_cached to prevent IsADirectoryError (Graphify-Labs#444) - report: skip structural-only communities with no real nodes (Graphify-Labs#443) - hooks: allow @ in python path allowlist for Homebrew paths (Graphify-Labs#474) - watch: keep source_file paths project-relative after rebuild (Graphify-Labs#434) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save_semantic_cacheaborts a whole batch withIsADirectoryErrorwhen a subagent emits a node whosesource_filehappens to be a directory path instead of a file. Observed on a TS/NestJS corpus where a subagent attributed an abstract base tosrc/common/database/abstracts/mongo/repositories(the containing folder).save_cached → file_hash → read_bytesthen crashes, so every other file in the batch fails to cache too.This PR makes the save path tolerant:
save_cached(path, ...)now no-ops whenpathis not a regular file.save_semantic_cache(...)usesp.is_file()instead ofp.exists()so directories are silently skipped.Real files in the same batch cache normally; the bogus entry is just dropped.
Changes
graphify/cache.py— 2 small defensive checks, docstring explaining the case.tests/test_cache.py— 3 new tests:test_save_cached_noop_on_directorytest_save_semantic_cache_skips_directory_source_file(mixed batch: real file + directory)test_save_semantic_cache_skips_missing_fileTest plan
pytest tests/test_cache.py— 15/15 pass (12 existing + 3 new)