Fix 'Solidify Stroke' node not appending elements in the BezPath after the first ClosePath element#2732
Merged
indierusty merged 3 commits intomasterfrom Jun 18, 2025
Merged
Conversation
Keavon
approved these changes
Jun 18, 2025
indierusty
changed the title
ClosePath element to the the VectorData.
indierusty
changed the title
ClosePath element to the the VectorData.
Keavon
changed the title
Keavon
pushed a commit
that referenced
this pull request
Jun 20, 2025
…r the first ClosePath element (#2732) Issue: Previously the `AppendBezpath::append_bezpath()` method didn't append the elements after the first `ClosePath` element in the given BezPath, but the Bezpath can contain more than one path. The 'Solidify Stroke' node creates at least two paths, but the `append_bezpath` method only appends the first path, and hence 'Solidify Stroke' didn't work correctly. Fix: Now `AppendBezpath::append_bezpath()` appends all the paths in the given BezPath, which also fixes the 'Solidify Stroke' node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Previously the
AppendBezpath::append_bezpath()method didn't append the elements after the firstClosePathelement in the given BezPath, but the Bezpath can contain more than one path. The 'Solidify Stroke' node creates at least two paths, but theappend_bezpathmethod only appends the first path, and hence 'Solidify Stroke' didn't work correctly.Fix:
Now
AppendBezpath::append_bezpath()appends all the paths in the given BezPath, which also fixes the 'Solidify Stroke' node.Fixes : https://discord.com/channels/731730685944922173/1372783056632549386/1384742146241724577