Skip to content

Fix 'Solidify Stroke' node not appending elements in the BezPath after the first ClosePath element #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
indierusty merged 3 commits into from
Jun 18, 2025
Merged

Fix 'Solidify Stroke' node not appending elements in the BezPath after the first ClosePath element #2732

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01d059f
fix append_bezpath method
indierusty Jun 18, 2025
c9b463b
Merge branch 'master' into ir/append-bezpath
indierusty Jun 18, 2025
1481ea4
Merge branch 'master' into ir/append-bezpath
Keavon Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions node-graph/gcore/src/vector/vector_data/modification.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,15 @@ impl<'a> AppendBezpath<'a> {
self.last_point_index = Some(next_point_index);
}

fn reset(&mut self) {
self.first_point = None;
self.last_point = None;
self.first_point_index = None;
self.last_point_index = None;
self.first_segment_id = None;
self.last_segment_id = None;
}

pub fn append_bezpath(vector_data: &'a mut VectorData, bezpath: BezPath) {
let mut this = Self::new(vector_data);
let mut elements = bezpath.elements().iter().peekable();
Expand Down Expand Up @@ -621,8 +630,8 @@ impl<'a> AppendBezpath<'a> {
}
}
PathEl::ClosePath => {
// Already handled using `append_segment_and_close_path()`;
break;
// Already handled using `append_segment_and_close_path()` hence we reset state and continue.
this.reset();
}
}
}
Expand Down
Loading