Skip to content

Fix selection jumping back to previously selected node after its drag abort, upon clicking to select a new node#3696

Merged
Keavon merged 2 commits intoGraphiteEditor:masterfrom
Annonnymmousss:fix-stale_state
Jan 28, 2026
Merged

Fix selection jumping back to previously selected node after its drag abort, upon clicking to select a new node#3696
Keavon merged 2 commits intoGraphiteEditor:masterfrom
Annonnymmousss:fix-stale_state

Conversation

@Annonnymmousss
Copy link
Copy Markdown
Contributor

@Annonnymmousss Annonnymmousss commented Jan 28, 2026

closes #3695

the select_if_not_dragged state was not getting cleared after changes..

Screen.Recording.2026-01-28.at.3.37.46.PM.mov

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jan 28, 2026

!build

@github-actions
Copy link
Copy Markdown

📦 Build Complete for e5818d6
https://57f0bb1e.graphite.pages.dev

@Annonnymmousss Annonnymmousss marked this pull request as draft January 28, 2026 12:52
@Annonnymmousss Annonnymmousss marked this pull request as ready for review January 28, 2026 13:08
@Annonnymmousss
Copy link
Copy Markdown
Contributor Author

In my earlier commit I forgot to change the state when the dragging is abort with esc key.. fixed it...

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jan 28, 2026

!build

@github-actions
Copy link
Copy Markdown

📦 Build Complete for e5a01e7
https://13c9915f.graphite.pages.dev

@Keavon Keavon changed the title fix : Selection jumps back to previously selected node after its drag abort, upon clicking to select new node. Fix selection jumping back to previously selected node after its drag abort, upon clicking to select a new node Jan 28, 2026
Copy link
Copy Markdown
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean fix, thank you!

@Keavon Keavon merged commit da51885 into GraphiteEditor:master Jan 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selection jumps back to previously selected node after its drag abort, upon clicking to select new node

2 participants