Skip to content

More consistent document crate names#4323

Merged
timon-schelling merged 4 commits into
masterfrom
rename-document-crates
Jul 15, 2026
Merged

More consistent document crate names#4323
timon-schelling merged 4 commits into
masterfrom
rename-document-crates

Conversation

@timon-schelling

@timon-schelling timon-schelling commented Jul 10, 2026

Copy link
Copy Markdown
Member
[workspace.dependencies]
...
document-graph-storage = { path = "document/graph-storage", default-features = false }
document-format = { path = "document/format" }
document-container = { path = "document/container" }
...

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the graph-storage crate to document-graph and updates all references, imports, and documentation across the codebase to reflect this change. The review feedback identifies minor layout alignment issues in the ASCII art diagrams within the document-format.md RFC document caused by the difference in name lengths, and provides suggestions to correct the formatting.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread node-graph/rfcs/document-format.md Outdated
Comment thread node-graph/rfcs/document-format.md Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Confidence score: 5/5

  • Safe to merge after the addressed issues were fixed.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/rfcs/document-format.md Outdated
Comment thread node-graph/rfcs/document-format.md Outdated
@timon-schelling
timon-schelling force-pushed the rename-document-crates branch from b5d4ed8 to 08da582 Compare July 15, 2026 12:21
@timon-schelling
timon-schelling added this pull request to the merge queue Jul 15, 2026
Merged via the queue into master with commit dc813e3 Jul 15, 2026
10 checks passed
@timon-schelling
timon-schelling deleted the rename-document-crates branch July 15, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants