Desktop: Make input routing aware of floating menus

[timon-schelling]

No description provided.

[cubic-dev-ai]

All reported issues were addressed

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

All reported issues were addressed across 11 files (changes from recent commits).

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

2 issues found across 7 files (changes from recent commits).

Confidence score: 3/5

• In frontend/src/components/panels/Document.svelte, removing the reportFloatingMenuClose(textboxId) cleanup can leave textToolInteractiveInputElement permanently set when the Document panel is destroyed, affecting later text-input behavior — restore equivalent cleanup on destruction.
• In frontend/src/components/layout/FloatingMenu.svelte, the destruction callback can re-enable native direct input after destroyInputManager() has disabled it, leaving editor input in an inconsistent state — guard menu-state updates during manager teardown.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="frontend/src/components/panels/Document.svelte">

<violation number="1">
P2: Removing the `reportFloatingMenuClose(textboxId)` call from `onDestroy` leaves `textToolInteractiveInputElement` in `src/utility-functions/input.ts` permanently set when the Document panel is destroyed while its text box is open. That module-level state is only cleared by the `modifyinputfield` event that `displayRemoveEditableTextbox()` dispatches; there is no destroy-time path anymore. By contrast the removed code cleaned up on destroy. Result: `updateDirectInput` keeps `directInputEnabled = false` (desktop direct input stays off) and `onPointerUp`/`onPointerDown` keep treating clicks as text commits for any subsequently opened document. Dispatch `modifyinputfield` with `undefined` (or clear `textToolInteractiveInputElement`) in Document.svelte's `onDestroy`.</violation>
</file>

<file name="frontend/src/components/layout/FloatingMenu.svelte">

<violation number="1" location="frontend/src/components/layout/FloatingMenu.svelte:167">
P2: When the editor is torn down with a floating menu mounted, this `onDestroy` callback can re-enable native direct input after `destroyInputManager()` has disabled it. Guard menu-state updates during manager teardown or perform the final disable after all child components are destroyed.</violation>
</file>

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: When the editor is torn down with a floating menu mounted, this onDestroy callback can re-enable native direct input after destroyInputManager() has disabled it. Guard menu-state updates during manager teardown or perform the final disable after all child components are destroyed.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At frontend/src/components/layout/FloatingMenu.svelte, line 167:

<comment>When the editor is torn down with a floating menu mounted, this `onDestroy` callback can re-enable native direct input after `destroyInputManager()` has disabled it. Guard menu-state updates during manager teardown or perform the final disable after all child components are destroyed.</comment>

<file context>
@@ -163,7 +164,7 @@
 
 	onDestroy(() => {
-		reportFloatingMenuClose(menuId);
+		onFloatingMenuOpenChange(menuId, false, editor);
 		containerResizeObserver.disconnect();
 		dialogResizeObserver?.disconnect();
</file context>

[Keavon]

Nit: UI would look a bit nicer.