fix(client): reject brace-match tool calls with trailing prose - #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Phase 3 medium audit finding (E4): the Tier 3 inline tool-call fallback in
client/core/stream.go(parseBraceMatchToolCall) would treat any JSON-shaped{"name": ..., "arguments": {...}}object found anywhere in a response as a tool call to execute — including JSON examples in prose or inside code fences. This is a false-positive execution risk: model output that merely illustrates a tool call would be executed.Fix
parseBraceMatchToolCallnow requires the candidate JSON object to run to the end of the response (ignoring trailing whitespace). If any prose follows the closing}, the text is treated as an example/explanation, not a tool call. The engine-level gates inengine/host_runtime.goandclient/aliases.goare unchanged — both delegate to the single real implementation.Tests
TestParseBraceMatch_JSONExampleInProseNotExecuted— example followed by prose ⇒ no callTestParseBraceMatch_FencedJSONExampleNotExecuted— JSON in code fences ⇒ no callTestParseBraceMatch_TrailingWhitespaceStillParsed— trailing whitespace (common in generation) still yields a callVerified:
go test ./client/... ./engine/all green.