feat(acp): client docs, agent-loop smoke scorecard, remove BackgroundAgentPool - #177
Merged
Patel230 merged 1 commit intoAug 5, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three backlog items from the control-plane roadmap, stacked on #176:
BackgroundAgentPool(deprecation → removal). The type,constructors,
FormatResults, and reexport shims are gone. Zero productioncallers existed;
Session.SpawnController()+taskruntime.Registryis thepath. Deletes
internal/engine/agent/background_agent.go(+ its test).docs/acp/client.md: wire protocol, worked lifecycleexample (
session/new→setMode→setIsolation→status→prompt),and a stdlib-only reference client. Matches the real JSON shapes (structured
prompt array,
hawksnapshot).hawk eval smoke: headless agent-loop smokebenchmark. Drives the real
Session.Streamloop with a stub provider (noAPI key, CI-safe) and scores steps / tool calls / token usage per task.
Fixtures:
smoke-read-file(≥1 Read tool call),smoke-no-tools(clean termination).
internal/feature/eval/{smoke,headless,smoke_test}.go.Test plan
go test ./internal/feature/eval/ ./internal/engine/ ./internal/engine/agent/ ./internal/acp/go build ./... && go vet ./internal/feature/eval/ ./cmd/go run ./cmd/hawk eval smoke→ 2/2 pass