Skip to content

feat(acp): client docs, agent-loop smoke scorecard, remove BackgroundAgentPool - #177

Merged
Patel230 merged 1 commit into
feat/acp-set-mode-and-deprecationsfrom
feat/acp-docs-pool-removal-scorecard
Aug 5, 2026
Merged

feat(acp): client docs, agent-loop smoke scorecard, remove BackgroundAgentPool#177
Patel230 merged 1 commit into
feat/acp-set-mode-and-deprecationsfrom
feat/acp-docs-pool-removal-scorecard

Conversation

@Patel230

@Patel230 Patel230 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Three backlog items from the control-plane roadmap, stacked on #176:

  1. Remove BackgroundAgentPool (deprecation → removal). The type,
    constructors, FormatResults, and reexport shims are gone. Zero production
    callers existed; Session.SpawnController() + taskruntime.Registry is the
    path. Deletes internal/engine/agent/background_agent.go (+ its test).
  2. ACP client docsdocs/acp/client.md: wire protocol, worked lifecycle
    example (session/newsetModesetIsolationstatusprompt),
    and a stdlib-only reference client. Matches the real JSON shapes (structured
    prompt array, hawk snapshot).
  3. Benchmark scorecardhawk eval smoke: headless agent-loop smoke
    benchmark. Drives the real Session.Stream loop with a stub provider (no
    API key, CI-safe) and scores steps / tool calls / token usage per task.
    Fixtures: smoke-read-file (≥1 Read tool call), smoke-no-tools
    (clean termination). internal/feature/eval/{smoke,headless,smoke_test}.go.

Test plan

  • go test ./internal/feature/eval/ ./internal/engine/ ./internal/engine/agent/ ./internal/acp/
  • go build ./... && go vet ./internal/feature/eval/ ./cmd/
  • go run ./cmd/hawk eval smoke → 2/2 pass
  • Pre-commit hooks (fmt/lint/imports) green

@Patel230
Patel230 merged commit 63c6d05 into feat/acp-set-mode-and-deprecations Aug 5, 2026
@Patel230
Patel230 deleted the feat/acp-docs-pool-removal-scorecard branch August 5, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant