Sync stale submodule snapshot: restore test helpers + gofumpt#21
Merged
Conversation
…dit tools - Add Specialist framework (internal/specialist/) for sub-agent permissions - Add Eval framework (internal/eval/) with test suites and scoring - Add Hook system (internal/hook/) for lifecycle hooks - Update Graph package with cleaner API - Update Audit package with 12 tests - Update Browser tool with fixed imports - Update Tool package with proper initialization All tests pass: audit(12), eval(11), graph(9), hook(10), tool(9)
- Update config.go with cleaner initialization - Update docs/architecture.md with new diagrams - Update options.go with better defaults - Update reviewer.go with improved logic - Remove outdated sight_test.go (tests moved to internal packages) This commit cleans up the external/sight submodule after porting features from Gitlawb/zero.
- Integer-overflow guards on numeric conversions - File/dir permission tightening (0600/0750) - Path-traversal cleaning and error-return handling - Narrow, justified #nosec annotations where risk is not applicable Module now scans clean with gosec (0 issues).
The refactor commit that removed stale tests/docs deleted sight_test.go entirely, but it defined mockProvider and testDiff which describe_test.go, autofix_test.go, and improve_test.go still depend on -- leaving the package in a state where 'go build' succeeds (test files aren't compiled) but 'go vet'/'go test' fail outright. Restore the maintained version of sight_test.go from the standalone sight repo (which never dropped it) and apply gofumpt to the files flagged by CI's format check.
…eshold - internal/specialist: parseYAML computed description/tools locally but never wrote them to the *SpecialistManifest target, so specialists loaded from disk always got empty Description/Tools regardless of file content. Fix it to actually populate the manifest. - internal/specialist: LoadProjectSpecialists's multi-location fallback never reached its second location, because a missing directory is not treated as an error by loadSpecialistsFromDir, so the loop always returned after the first (usually absent) location. Load from every existing location instead of stopping at the first non-error result. - internal/specialist: LoadUserSpecialists mutated the specialists map without holding Manager's mutex, unlike every other method on Manager. - internal/graph: processFuncDecl only handled non-pointer receivers (*ast.Ident), so any pointer-receiver method -- the common case in Go -- lost its type name and was recorded as a bare function. - Added specialist_test.go (0% covered previously) and a Build test for internal/graph (34.3% covered previously, now 82.1%), bringing overall package coverage from 69.6% to 74.4%, above CI's 74% threshold.
- internal/eval: use strings.ReplaceAll instead of strings.Replace(...,-1)
- internal/graph: use a tagged switch on depth instead of switch{cond},
and replace a manual append loop with append(dst, src...)
- internal/hook: remove parseHookContent, an unused method superseded by
extractCommand and never called from anywhere in the package
- reviewer.go: remove reviewGraphEnabled, an unused method -- graph-based
review gating is handled directly via cfg.graphEnabled at the call site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch fixes real breakage found while triaging hawk's CI `build-and-push` job (which fetches this submodule by exact commit SHA):