Upgrade go-git to v6 alpha.4, fixing GO-2026-5496 (external/trace snapshot)#49
Merged
Merged
Conversation
- Integer-overflow guards on numeric conversions - File/dir permission tightening (0600/0750) - Path-traversal cleaning and error-return handling - Narrow, justified #nosec annotations where risk is not applicable Module now scans clean with gosec (0 issues).
- Migrate all call sites to the new Worktree.Filesystem() method API - Fix zero-hash tree entry rejection in v2_generation_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch is off an older, diverged checkout of trace used as hawk's
external/tracegit submodule (pinned at38a3993). The same fix has already been applied to the up-to-date trace repo in PR #48; this PR brings the security fix to this older submodule snapshot until it can be re-synced to trace's current main.Worktree.Filesystem()method APIv2_generation_test.goTest plan
GOWORK=off go build ./...GOWORK=off go vet ./...GOWORK=off go test ./...