Add "os.description" non-identifying attribute to the AgentDescription - #87
Merged
Conversation
Member
Author
|
I had to update dependencies again to make the build work. |
The gopsutil data doesn't return the properly spelled Linux distribution names.
Also improve tests.
Also improve test coverage and os-release value parsing.
Better fallback handling in getOSDescription().
kroepke
approved these changes
Aug 5, 2026
kroepke
left a comment
kroepke
left a comment
Member
There was a problem hiding this comment.
much nicer! tested against a Win 11 Pro as well, to check something that wasn't in the fixtures, worked as expected.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "os.description" attribute contains the full operating system name and version.
Fixes Graylog2/graylog2-server#25176