Missing the milliseconds in Graylog

[FerhatSavci]

Line 146 in message.go (v2.0 branch) is currently:

TimeUnix: float64(time.Now().Unix()),

Unix time is in seconds since 1.1.1970, thus, log entries in Graylog get the milliseconds truncated.

TimeUnix: float64(time.Now().UnixNano()) / float64(time.Second.Nanoseconds()),

works nicely.

Best regards.

[valentin-krasontovitsch]

there's a merge request for this already: #23. Although I hardcoded the time.Second.Nanoseconds() as 1e9... I must admit that your solution is more expressive, hence in my opinion betterer.

Not sure why it hasn't been merged yet though.

[che]

Could you add time.Second.Nanoseconds() also for TLS branch?
Thanks!

P.S. Maybe make sense to create branch v3 where to merge v2 and tls branches?

[valentin-krasontovitsch]

After a quick look, it seems to me that the tls branch can easily be rebased on top of the current v2 branch, and merged afterwards - in my humble opinion, there's not even any need to cut a new release, as this would simply constitute an extension of the currently existing API, without any (breaking) changes in existing behaviour...

gonna wait a bit though for the short vs. long message merge request (#34) to be accepted, as that one requires some editing of the tests introduced in tls.

[che]

Great!
I'll waiting.
And on this moment merging v2 and tls branches works fine.
Thanks!

[netbidev]

Hello.

I am waiting.