Turn permission error into validation error for empty streams in event definition.#22778
Merged
Turn permission error into validation error for empty streams in event definition.#22778
Conversation
943d580 to
66d7f99
Compare
janheise
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is based on #22771, which needs to be merged before.
Description
Motivation and Context
This PR is making sure that if a user is creating an event definition, does not have the global
streams:readpermission and has an emptystreamsfield in the event definition config, a validation error will be returned instead of a 403. This way, the frontend can handle it and show the user a helpful message in the event definition creation dialog instead of ending up on an error page.Fixes Graylog2/graylog-plugin-enterprise#10869.
/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/10970
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: