Add wander ranges for all npcs - #1123
Merged
Merged
Conversation
GregHib
commented
Aug 2, 2026
Owner
- Add a dump of official wander and max ranges from rs3 (manually scanned through for npc mismatches)
- Remove current wander ranges from npcs.toml
- Replace current combat retreat_range's with max_range
- Remove special characters from some dungeoneering npc ids
- Remove incorrect port_sarim_guard_7 npcs
- Fix random events triggering whilst delayed
Contributor
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 5 files with indirect coverage changes @@ Coverage Diff @@
## main #1123 +/- ##
============================================
- Coverage 44.02% 44.02% -0.01%
Complexity 9783 9783
============================================
Files 1951 1951
Lines 84661 84663 +2
Branches 14018 14021 +3
============================================
- Hits 37276 37275 -1
Misses 41995 41995
- Partials 5390 5393 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.